Merged
Conversation
merryman
force-pushed
the
fix/require-bun-rust-install
branch
4 times, most recently
from
9c2d2c4 to
9eae2ca
Compare
- Add ExportedImportCapturePass matching Babel's insertCapturesForExportedImports - Implement function declaration wrapping via declarationWrapper (__define__) restricted to function declarations only (matching Babel's bundler behavior) - Fix namespace transforms: import * as ns, export * from, export * as ns from - Fix SyntaxContext preservation to prevent SWC hygiene renaming (Path→Path1) - Fix __module_exports__ format to match Babel (per-specifier entries, __reexport__) - Fix default export captures for all forms (decl, expr, literal) - Harden __define__ runtime: only set .name on functions, guard metadata - Add 163 Rust tests aligned with Babel's capturing-test.js test suite - Loading screen builds and loads with 0 errors on both fastLoad modes
merryman
force-pushed
the
fix/require-bun-rust-install
branch
from
9eae2ca to
a30527e
Compare
- Add "module" and "import" to generator env conditions for proper ESM browser resolution - Skip native binary packages (@rollup/rollup-*, @swc/core-*) and wildcard/git deps that can't resolve on jspm.io CDN - Auto-pin transitive deps to available CDN versions when jspm.io 404s - Log import map resolution failures for debugging
Modules like underscore export `hasOwnProperty` as a named export, which shadows Object.prototype.hasOwnProperty on the renamedExports object when populated via getExportDecls. Object.hasOwn is immune to this since it doesn't go through the object's prototype chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shearly when Bun or the Rust toolchain is missing instead of using the untested fallback pathsxcode-select --installprerequisite for Rustinstall.shCloses #1789
Verification
bash -n install.shnode --check lively.project/templates/test-action.jsnode --check lively.project/templates/build-upload-action.jsnode --check lively.project/templates/deploy-pages-action.jsPATHand confirminstall.shexits with Bun install instructionsPATH, and confirminstall.shexits with Rust install instructions